Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc org update #87

Merged
merged 8 commits into from
Jan 13, 2021
Merged

Misc org update #87

merged 8 commits into from
Jan 13, 2021

Conversation

dannys42
Copy link
Contributor

No description provided.

@dannys42 dannys42 added the jazzy-doc When applied to a PR, instructs Package-Builder to regenerate the Jazzy documentation label Nov 26, 2020
@dannys42 dannys42 requested a review from mbarnach November 26, 2020 00:40
mbarnach
mbarnach approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@mbarnach mbarnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mbarnach
mbarnach approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@mbarnach mbarnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mbarnach
Copy link
Member

mbarnach commented Dec 8, 2020

@dannys42 I think the tests can be fixed by the PR #88

@dannys42
Copy link
Contributor Author

dannys42 commented Dec 9, 2020

@mbarnach ah cool, thanks for that.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 70 Security Hotspots
Code Smell A 12 Code Smells

No Coverage information No Coverage information
86.7% 86.7% Duplication

@dannys42 dannys42 mentioned this pull request Jan 13, 2021
Open
@dannys42
Copy link
Contributor Author

The swift-development build is failing for some reason. I added an issue (#89) to keep track of this. Since the rest of the builds are succeeding, I'm pushing this through in order to continue updating packages that depend n SwiftyRequest.

@dannys42 dannys42 merged commit 2c54377 into Kitura:master Jan 13, 2021
@dannys42 dannys42 deleted the MISC-org_update branch January 13, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbarnach mbarnach mbarnach approved these changes

Assignees
No one assigned
Labels
jazzy-doc When applied to a PR, instructs Package-Builder to regenerate the Jazzy documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannys42 @mbarnach