#6300 Fix wrong Feature Tree when switching to kcl file with errors #6922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
e2e/playwright/sketch-tests.spec.ts
Outdated
|
|
||
| await toolbar.openFile('error.kcl') | ||
|
|
||
| // Ensure filetree is populate |
There was a problem hiding this comment.
There appears to be a typo in the comment: Ensure filetree is populate should be Ensure filetree is populated for grammatical correctness.
Suggested change
| // Ensure filetree is populate | |
| // Ensure filetree is populated |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
pierremtb
approved these changes
May 14, 2025
e2e/playwright/sketch-tests.spec.ts
Outdated
| await toolbar.openFile('error.kcl') | ||
|
|
||
| // Ensure filetree is populate | ||
| await page.waitForTimeout(1000) |
There was a problem hiding this comment.
Maybe this again here?
Suggested change
| await page.waitForTimeout(1000) | |
| await scene.settled(cmdBar) |
There was a problem hiding this comment.
Thanks, that seems to work too and much better!
Comment on lines
+150
to
+153
|
|
||
| // These belonged to the previous file | ||
| this.lastSuccessfulOperations = [] | ||
| this.lastSuccessfulVariables = {} |
pierremtb
deleted the
andrewvarga/6300/wrong-feature-tree-when-switching-to-file-with-kcl-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6300