Skip to content

Make a few app header items hide naively as the window narrows #6776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

franknoirot
Copy link
Contributor

@franknoirot franknoirot commented May 8, 2025

We should eventually be smarter about making the top UI more minimal as the screen narrows, but for now we can at least do a tiny bit of responsiveness.

Demo

Screenshare.-.2025-05-08.12_32_40.PM-compressed.mp4

Copy link

vercel bot commented May 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 4:42pm

Copy link

qa-wolf bot commented May 8, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@franknoirot franknoirot requested a review from a team May 8, 2025 16:33
@franknoirot franknoirot changed the title Make stuff hide as the window narrows naively Make a few app header items hide naively as the window narrows May 8, 2025
@pierremtb
Copy link
Contributor

@franknoirot I think our playwright test window might fall in narrow range and can't find the buttons

@nadr0
Copy link
Contributor

nadr0 commented May 8, 2025

@franknoirot I think our playwright test window might fall in narrow range and can't find the buttons

Maybe if it is using text find, we could swap it to a data-testid?

@franknoirot
Copy link
Contributor Author

@franknoirot I think our playwright test window might fall in narrow range and can't find the buttons

big oof!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants