-
Notifications
You must be signed in to change notification settings - Fork 70
Add involute to Path info #6448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
let angle = (end_radius * end_radius - start_radius * start_radius).sqrt() / start_radius; | ||
0.5 * start_radius * angle * angle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The calculation (end_radius * end_radius - start_radius * start_radius).sqrt() / start_radius
will produce a runtime error if end_radius < start_radius
, as it would attempt to take the square root of a negative number. This is particularly problematic when the reverse
flag is set to true, which suggests the path should go from end_radius to start_radius. Consider adding a validation check or using abs()
to ensure the calculation is always performed on a positive value.
let angle = (end_radius * end_radius - start_radius * start_radius).sqrt() / start_radius; | |
0.5 * start_radius * angle * angle | |
let angle = ((end_radius * end_radius - start_radius * start_radius).abs()).sqrt() / start_radius; | |
0.5 * start_radius * angle * angle |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
CodSpeed Instrumentation Performance ReportMerging #6448 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6448 +/- ##
==========================================
- Coverage 85.26% 85.18% -0.09%
==========================================
Files 109 109
Lines 47021 47074 +53
==========================================
+ Hits 40092 40098 +6
- Misses 6929 6976 +47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The circular involute sketch segment was using ToPoint as its path type. This adds a specific involute path type