Skip to content

Backoff Reconnect #6358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
May 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
0530d12
Add a Stop command that does a bit of cleanup in the engineStateMachine
lee-at-zoo-corp Apr 28, 2025
77847b7
Major network code startup refactor; backoff reconnect; many more log…
lee-at-zoo-corp Apr 28, 2025
3b1ece3
Save camera state after every user interaction in case of disconnecti…
lee-at-zoo-corp Apr 28, 2025
fac0804
Translate basic WebSocket error numbers into useful text
lee-at-zoo-corp Apr 28, 2025
6c07ae8
Add a RestartRequest event to the engineCommandManager
lee-at-zoo-corp Apr 28, 2025
cc0aef6
Adjust for a rebase
lee-at-zoo-corp Apr 28, 2025
60f59b1
Add E2E test for stream pause behavior
lee-at-zoo-corp Apr 29, 2025
d3545a8
Fix snapshot test
lee-at-zoo-corp Apr 30, 2025
f54582f
fmt, lint
lee-at-zoo-corp Apr 30, 2025
903e78c
Merge branch 'main' into lee-at-zoo-corp/backoff-reconnect
lee-at-zoo-corp Apr 30, 2025
ba8cc78
Merge branch 'main' into lee-at-zoo-corp/backoff-reconnect
lee-at-zoo-corp May 1, 2025
d4c7e85
Merge branch 'main' into lee-at-zoo-corp/backoff-reconnect
lee-at-zoo-corp May 2, 2025
4017d1b
Merge branch 'main' into lee-at-zoo-corp/backoff-reconnect
lee-at-zoo-corp May 14, 2025
fb5c5cc
small issue
lee-at-zoo-corp May 14, 2025
ffaa05f
Fix tests
lee-at-zoo-corp May 14, 2025
eb9d177
Fix up idle test
lee-at-zoo-corp May 14, 2025
99863f1
One last fix
lee-at-zoo-corp May 14, 2025
4f64c32
fixes
lee-at-zoo-corp May 14, 2025
ee590a0
Remove circ dep
lee-at-zoo-corp May 14, 2025
1f0c914
fix test
lee-at-zoo-corp May 15, 2025
b3296bc
use a const for time
lee-at-zoo-corp May 15, 2025
da9d294
TEST -> isPlaywright instead
lee-at-zoo-corp May 15, 2025
b8e6d53
whoops
lee-at-zoo-corp May 15, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions e2e/playwright/snapshot-tests.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -766,7 +766,7 @@ test.describe('Grid visibility', { tag: '@snapshot' }, () => {
})
})

test('theme persists', async ({ page, context }) => {
test('theme persists', async ({ page, context, homePage }) => {
const u = await getUtils(page)
await context.addInitScript(async () => {
localStorage.setItem(
Expand All @@ -784,7 +784,7 @@ test('theme persists', async ({ page, context }) => {

await page.setViewportSize({ width: 1200, height: 500 })

await u.waitForAuthSkipAppStart()
await homePage.goToModelingScene()
await page.waitForTimeout(500)

// await page.getByRole('link', { name: 'Settings Settings (tooltip)' }).click()
Expand Down Expand Up @@ -812,7 +812,7 @@ test('theme persists', async ({ page, context }) => {
// Disconnect and reconnect to check the theme persists through a reload

// Expect the network to be down
await expect(networkToggle).toContainText('Offline')
await expect(networkToggle).toContainText('Problem')

// simulate network up
await u.emulateNetworkConditions({
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading