Fix sketch-on-face sketches to be in the artifact graph #5489
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| for exec_artifact in exec_artifacts.values() { | ||
| merge_artifact_into_map(&mut map, exec_artifact.clone()); | ||
| } |
There was a problem hiding this comment.
This is the core of the change.
It's unfortunate that there are two loops, this one and the one above. I think this might cause some problems when there are multiple sketches-on-face/place on the same face/plane.
jtran
force-pushed
the
jtran/plane-code-ref
branch
from
0f00752 to
88b06d1
Compare
jtran
force-pushed
the
jtran/plane-code-ref
branch
from
88b06d1 to
1d627a4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5489 +/- ##
==========================================
+ Coverage 86.28% 86.31% +0.03%
==========================================
Files 95 95
Lines 35900 35909 +9
==========================================
+ Hits 30975 30996 +21
+ Misses 4925 4913 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Part of #5385.
This PR makes sketch-on-face and sketch-on-plane less special. See the issue for why this matters, but the tl;dr is now that the artifact graph is built in Rust, we can remove special cases that were incomplete and broken.