Bugfix: wait for settings loading before onboarding redirect check #5470
Conversation
If you refresh the app while viewing a file, the settingsActor could not have loaded the user settings before checking the onboardingStatus setting. This uses a subscription on the settingsActor to await the "init" state, after the user settings have loaded.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
franknoirot
requested review from
jtran,
lf94,
nadr0,
pierremtb and
Irev-Dev
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5470 +/- ##
=======================================
Coverage 86.02% 86.02%
=======================================
Files 95 95
Lines 35754 35754
=======================================
Hits 30757 30757
Misses 4997 4997
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@pierremtb pointed out some major flaws with the current approach, and upon reflection this is not at all the way to do this. The function for the loader will have already returned with |
franknoirot
force-pushed
the
franknoirot/adhoc/dont-redirect-unless-settings-loaded
branch
from
16b9b78 to
4356b2b
Compare
If you refresh the app while viewing a file, the settingsActor could not have loaded the user settings before checking the onboardingStatus setting. This uses a
useEffectto subscribe to navigation events and trigger navigation to the onboarding if necessary. It adds aTODOcomment with the approach that should be taken once router data and methods can be slotted into theappMachineand the navigation can occur after the user settings are loaded, without needing to touch React.