Fix Second-Body Extrude Selection #5456
Draft
+119
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5456 +/- ##
=======================================
Coverage 86.02% 86.02%
=======================================
Files 95 95
Lines 35754 35754
=======================================
Hits 30757 30757
Misses 4997 4997
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ittyCAD/modeling-app into max-fillet-pipes-to-wrong-body
…ittyCAD/modeling-app into max-fillet-pipes-to-wrong-body
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
getPathToExtrudeForSegmentSelectionto derive the extrude from thesegmentorsweepEdgeartifactrather than scanning bypath ID. Thanks @Irev-Dev for help !This ensures the correct body is always selected when adding fillets/chamfers (previously, the second extrude could mistakenly point to the first). (in piped cases)
Introduces
getSweepArtifactFromSelectionto retrieve the parent sweep from either a segment or a sweepEdge.Adds two new test cases verifying that a second extrude referencing the first extrude’s face is correctly identified (both piped and standalone).
We now reliably link selections (segments/edges) to the right extrude, eliminating the “fillet on the wrong body” bug.
Closes: #5358