Initiate connection when we receive SDP and don't connect when null #5451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5451 +/- ##
=======================================
Coverage 86.02% 86.02%
=======================================
Files 95 95
Lines 35754 35754
=======================================
Hits 30757 30757
Misses 4997 4997
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sometimes clients were gathering ice candidates faster than we returning the SDP answer, which meant we tried to parse a null as the remote description. Clean up tsc error and add log on timeout
iterion
force-pushed
the
initiate-connection-on-sdp-answer-and-guard-null
branch
from
14e53d6 to
77cf058
Compare
lf94
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes clients were gathering ice candidates faster than we returning the SDP answer, which meant we tried to parse a null as the remote description.