Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sporadic SyntaxError on build-apps mac job #4199

Closed
pierremtb opened this issue Oct 17, 2024 · 3 comments · Fixed by #4270
Closed

Fix sporadic SyntaxError on build-apps mac job #4199

pierremtb opened this issue Oct 17, 2024 · 3 comments · Fixed by #4270
Assignees
@pierremtb

Comments

@pierremtb
Copy link
Collaborator

Image
@pierremtb pierremtb self-assigned this Oct 17, 2024
@pierremtb
Copy link
Collaborator Author

I believe the issue is at the notarization step Image

Wondering if there could be some sort of concurrent thing here. But more importantly, we should only notarize on release builds (aka Cut release PR or release or nightly), and it looks like we are notarizing everywhere at the moment. This needs to be addressed

pierremtb added a commit that referenced this issue Oct 23, 2024
@pierremtb
Separate debug/release electron-builder to help mac job
7cd3c35 
Will attempt to fix #4199
@pierremtb pierremtb mentioned this issue Oct 23, 2024
Merged
pierremtb added a commit that referenced this issue Oct 24, 2024
@pierremtb
Separate debug/release electron-builder to help mac job (#4270)
19d01c5 
* Separate debug/release electron-builder to help mac job
Will attempt to fix #4199

* Test BUILD_RELEASE: true

* Revert "Test BUILD_RELEASE: true"

This reverts commit f2c0c24.
@pierremtb
Copy link
Collaborator Author

Reopening. While #4270 helped making this happen less often (not on debug builds) we still need to address this for release builds, that are relied on by nightly and regular release builds.

I believe this is related electron/notarize#219

@pierremtb pierremtb reopened this Jan 2, 2025
@pierremtb pierremtb mentioned this issue Jan 2, 2025
Merged
@pierremtb
Copy link
Collaborator Author

Closing for now as #4892 adds a workaround

Took two attempts to notarize macos yesterday https://github.com/KittyCAD/modeling-app/actions/runs/12592588031/job/35097535178#step:11:360

It's the xcrun command https://github.com/KittyCAD/modeling-app/actions/runs/12592588031/job/35097535178#step:11:114

The folks in the upstream issue might be onto something electron/notarize#219

@kkerti kkerti mentioned this issue Jan 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pierremtb pierremtb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Separate debug/release electron-builder to help mac job KittyCAD/modeling-app
1 participant
@pierremtb