Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default unit to millimetres for unitless formats #754

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

alteous
Copy link
Contributor

@alteous alteous commented Feb 5, 2025

No description provided.

@alteous alteous requested a review from jessfraz February 5, 2025 17:08
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@e4a7772). Learn more about missing BASE report.

Files with missing lines Patch % Lines
modeling-cmds/src/format/obj.rs 0.00% 2 Missing ⚠️
modeling-cmds/src/format/ply.rs 0.00% 2 Missing ⚠️
modeling-cmds/src/format/stl.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #754   +/-   ##
=======================================
  Coverage        ?   25.20%           
=======================================
  Files           ?       35           
  Lines           ?     2107           
  Branches        ?        0           
=======================================
  Hits            ?      531           
  Misses          ?     1576           
  Partials        ?        0           
Flag Coverage Δ
unittests 25.20% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alteous alteous merged commit 1d22da3 into KittyCAD:main Feb 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants