-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in MachineState to the Control trait, HTTP Endpoint #118
Conversation
this is so i can figure out if we're mid-print to add more surface to the printers before job queues
example output: [
{
"id": "neptune",
"make_model": {
"manufacturer": "Elegoo",
"model": "Neptune 4",
"serial": null
},
"machine_type": "FusedDeposition",
"max_part_volume": {
"width": 250.0,
"depth": 250.0,
"height": 250.0
},
"state": "Idle",
"extra": {
"Moonraker": {}
}
},
{
"id": "nada",
"make_model": {
"manufacturer": "Zoo Corporation",
"model": "Null Machine",
"serial": "Cheerios"
},
"machine_type": "FusedDeposition",
"max_part_volume": {
"width": 500.0,
"depth": 600.0,
"height": 700.0
},
"state": "Unknown",
"extra": null
}
] |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
- Coverage 24.35% 23.89% -0.47%
==========================================
Files 46 47 +1
Lines 2459 2507 +48
==========================================
Hits 599 599
- Misses 1860 1908 +48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yeah i would be really nice to have the status of the printer in the modeling app |
also i just made a mental note to myself for the hackathon im gunna have to move the printers to the guest network or allow them on the guest network as well as machine api |
will figure out something because i do like the guest network being isolated from the rest of the office |
Oh good call |
I totally blanked and forgot we were contorting ourselves to drop "Print" or "Printer" from this. Changed to "Machine".
Going to land, happy to do any followups if this PR needs iteration @iterion |
This is a first step as we start to chip away on #68 slash #49 and others.
This will add a standard part of our "Control" trait to check on the state of a printer -- is the printer running? idle? paused mid-print? Broken?
I implemented this for Moonraker (since I was able to test it), and stubbed in Unknown elsewhere. USB is doable here -- and I think we can do Bambu, but that may wait until I get into the office to play with it myself.