Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT SUBMIT] Minimap concept #139

Open
wants to merge 437 commits into
base: master
Choose a base branch
from
Open

[DO NOT SUBMIT] Minimap concept #139

wants to merge 437 commits into from

Conversation

thatkookooguy
Copy link
Member

Change Summary

  • change short synopsis I [resolves #00]

    additional info about this mission

  • change short synopsis II (mission without additional info)

  • change short synopsis III

More info

(Free text here with additional photos, wikis, and additional needed information)

⚠️ MAKE SURE TO GO THROUGH THIS LIST ⚠️

(reviewers _shouldn't approve a PR without the next three checkboxs checked_)

Before you submit a PR, make sure you did the following things:

  • did you link this PR to an issue?

Make sure there's an issue open about the change you did (open one if there isn't). link this PR to that issue by writing resolves #{{issue_number}}. If this PR had several mission, link each issue in its parallel mission.

  • did you lint your changes to both javascript and scss?

hound can be pretty rough at keeping our code clean and readable! make sure you format your code by running either gulp format or gulp lint and cleaning out all the _lint errors. If you won't, you'll have a _long conversation with hound :-)

  • "I'm pretty sure I'll be able to read and understand this PR, even if I wasn't the author." - _said the PR author_

&:after {
content: '';
display: block;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule declaration should be followed by an empty line

letter-spacing: -1.5px;
line-height: 6px;

.ace_text-layer .ace_line {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selector ace_text-layer should be written in lowercase with hyphens
Selector ace_line should be written in lowercase with hyphens

display: inline;
font-size: 5px;
&:after {
content: '';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings

@thatkookooguy thatkookooguy temporarily deployed to kibibit-demo-pr-139 May 29, 2016 16:28 Inactive
@thatkookooguy thatkookooguy temporarily deployed to kibibit-demo-pr-139 May 29, 2016 23:32 Inactive
good doggy!
@ortichon
Copy link
Member

looks great on my machine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants