Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KHR_implicit_shapes extension Draft Proposal #2370
base: main
Are you sure you want to change the base?
KHR_implicit_shapes extension Draft Proposal #2370
Changes from 2 commits
1778abe
fddb953
c8bcbd3
757ab3b
f11f3ca
ef428bc
471f010
d04f5ab
ee968b6
c1e2fb3
682e8ee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spec says that boxes always have volume. Should the minimum be exclusive then?
Same comment regarding capsules, cylinders, and spheres.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, though engines tend to support this, it's probably not a useful construct. I've converted properties to exclusiveMinimum where it makes sense; though left the radii properties on capsules/cylinders alone - consider a cone, which has one radius of 0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be disallowed to have both radii as zeros? Although it's not easily representable with schemas, the spec may have such normative language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I've added language clarifying degenerate shapes (ef428bc) - one concern I have though, is how this requirement interacts with node scale; in particular, the third "Implementation Note" in section https://registry.khronos.org/glTF/specs/2.0/glTF-2.0.html#transformations which allows nodes to be "optimized away" if they have zero scale.
Similarly, I'd like if negative node scales were supported. i.e. a sphere attached to a node with scale [-1, -1, -1] should be identical to the sphere attached to a node with a scale of [1, 1, 1].
Have you any objection if we were to add text describing how to handle those cases?