Skip to content

Commit

Permalink
Fix review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
abbaswasim committed Jul 24, 2024
1 parent 9b731a6 commit 6b6d872
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions extensions/2.0/Khronos/KHR_texture_astc/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Written against the glTF 2.0 spec.

This extension adds the ability to specify textures using KTX v2 images with (ASTC compression)[https://github.com/ARM-software/astc-encoder/blob/main/Docs/FormatOverview.md]. An implementation of this extension can use such images as an alternative to the PNG or JPEG images available in glTF 2.0 for more efficient asset transmission, reducing GPU memory footprint, higher texture throughput and faster execution.

When this extension is used, it's allowed to use value `image/astc` for the `mimeType` property of images that are referenced by the `source` property of `KHR_texture_astc` texture extension object.
When this extension is used, it's allowed to use value `image/ktx2` for the `mimeType` property of images that are referenced by the `source` property of `KHR_texture_astc` texture extension object.

At runtime, engines can directly use the ktx images unlike EXT_texture_basisu which requires doing transcoding to other compressed formats. This also means you get support for all ASTC block formats and quality presets.

Expand Down Expand Up @@ -137,7 +137,7 @@ To use KTX v2 image with ASTC compression without a fallback, define `KHR_textur

## KTX v2 Images with Astc compression

To cover a broad range of use cases, this extension allows different ASTC block sizes as well as LDR, HDR and 3D images. These can be determined from the vkFormat of the KTX image.
To cover a broad range of use cases, this extension allows different ASTC block sizes as well as LDR, HDR and 3D images. These can be determined from the VkFormat of the KTX image.

For the purposes of this extension, the following texture types are defined:

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
"$schema": "http://json-schema.org/draft-04/schema",
"title": "KHR_texture_astc glTF Texture Extension",
"type": "object",
"description": "glTF extension to specify textures using the KTX v2 images with astc compression.",
"description": "glTF extension to specify textures using the KTX v2 images with ASTC compression.",
"allOf": [ { "$ref": "glTFProperty.schema.json" } ],
"properties": {
"source": {
"allOf": [ { "$ref": "glTFid.schema.json" } ],
"description": "The index of the image which points to a KTX v2 resource with astc compression."
"description": "The index of the image which points to a KTX v2 resource with ASTC compression."
},
"extensions": {},
"extras": {}
Expand Down

0 comments on commit 6b6d872

Please sign in to comment.