Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommercialRefrigerator #168

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

echadwick-artist
Copy link
Contributor

Commercial refrigerator with glass condensation, champagne bottles, and door animation.

This asset represents a small glass-fronted commercial refrigerator of the type seen commonly in convenience stores.

The asset was created on contract with the Khronos Group, to demonstrate a high quality model for e-commerce use, and to provide instructions on how to create similar assets using current industry-accepted 3D content creation techniques.

screenshot_Large

Commercial refrigerator with glass condensation, champagne bottles, and door animation.

This asset represents a small glass-fronted commercial refrigerator of the type seen commonly in convenience stores.

The asset was created to demonstrate a high quality model for e-commerce use, and to provide instructions on how to create similar assets using current industry-accepted 3D content creation techniques.
Replaced "Commercial Fridge" with 'Commercial Fridge'
@arpu
Copy link

arpu commented Feb 17, 2025

this looks fantasic! would be nice to have a open and a close animation

@echadwick-artist
Copy link
Contributor Author

echadwick-artist commented Feb 18, 2025

this looks fantasic! would be nice to have a open and a close animation

It has animation for the door, opening and closing. If you load it in a viewer that supports animation, you should see it!

Some info here about the animation and how it was done: https://github.com/KhronosGroup/glTF-Sample-Assets/blob/1d0cf80c48b1c6ebc1c6b8fa8ed1d932942084d6/Models/CommercialRefrigerator/README.body.md#animation

@arpu
Copy link

arpu commented Feb 18, 2025

Hey yes, i see the animatio , but its open/close in one animation clip, the idea is to start open animation and close seperate

@hybridherbst
Copy link
Contributor

hybridherbst commented Feb 18, 2025

Thanks, this is a nice asset!
Direct viewing link, nice for inspecting materials/textures/meshes and so on:

https://viewer.needle.tools/?file=https://github.com/KhronosGroup/glTF-Sample-Assets/blob/b4860b7b067c71b897a8a99b0b71c24f0163d6ee/Models/CommercialRefrigerator/glTF-Binary/CommercialRefrigerator.glb

image

@echadwick-artist
Copy link
Contributor Author

Nice viewer! Love all the options.

The link you posted doesn't work for me, but if I trim off the trailing "ee%2FModels%2FCommercialRefrigerator%2FglTF-Binary%2FCommercialRefrigerator.glb" then it works?

@javagl
Copy link
Contributor

javagl commented Feb 19, 2025

Indeed a nice model. That icey class will certainly pose a challenge for viewers.

But... I wouldn't write a comment if I didn't want to ask a stupid question 😁 : I wonder whether the bottles could benefit from EXT_mesh_gpu_instancing...?

@echadwick-artist
Copy link
Contributor Author

The great thing about permissive licenses is you’re free to remix the asset pretty much however you might like to. So, I encourage everyone to go for it! Make those animation clips, instance the bottles, set it up for interactivity! I would love to see what you can do with it. Only rule is to give credit, that’s it.

@echadwick-artist
Copy link
Contributor Author

Could we get a review and a merge from another Khronos member? Maybe @emackey or @javagl ?

Copy link

@bghgary bghgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick review and only made one minor comment. The only other thing I noticed is that the ORM and normal textures are in jpg format which I guess is working fine, but don't we normally avoid using jpg for non-color textures to avoid cross-talk between channels?


Then the textures were "baked" from their original UV layouts into the new UVs, using _Bake To Texture_ in 3ds Max.

![The Bake To Texture interface is shown with the desired render elements](screenshot/bake-to-texture.jpg)<br/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This image has a cursor in it. Maybe good to remove it.

Removed the cursor from the screenshot. Thanks for the tip Gary!
@echadwick-artist
Copy link
Contributor Author

It was difficult for me to see an improvement using PNGs instead for the ORMs and Normals, unless I zoomed in very close.

I compressed the Normal JPGs at 95/100, and the rest at 75/100. There is a bit of noise added to the interior Metallic, and the interior Occlusion is a bit blurrier.

Here's a version using PNG for ORM and Normal, it's about 16.7mb (versus 9.8mb with JPGs)
glTF-PNG-JPG.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants