-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SunglassesKhronos #147
SunglassesKhronos #147
Conversation
This is the first of four contracted "Hero Assets" for Khronos Group's 3D Commerce, a pair of sunglasses with an iridescent coating and featuring: * Efficient 3D modeling. * Face-weighted vertex normals for clean shading and optimal compression. * Optimal texture packing. * glTF extensions iridescence, transmission, and volume. * No ambient occlusion applicable since it is mostly metal and glass. * Extensive tutorial for asset creation in the readme.
|
||
After conversion, the resulting glTF was then optimized with [RapidPipeline 3D Processor](https://docs.rapidpipeline.com/docs/componentDocs/3dProcessor/3d-processor-overview) to compact the data by removing unneeded information. In this case no decimation was required since the model uses only 13,396 triangles. | ||
|
||
A variant with lossy compression was created with another run of RapidPipeline 3D Processor, applying Draco geometry compression and WEBP texture compression. This compressed the glTF from 371,212 bytes down to 63,146 bytes, a 83% reduction in size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: spell WEBP as WebP.
@@ -0,0 +1,47 @@ | |||
{ | |||
"version": 2, | |||
"legal": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be explicit copyright info for all the images (especially photos) used in the readme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. We have photos in other readmes, without explicit licensing. For example https://github.com/KhronosGroup/glTF-Sample-Assets/tree/main/Models/AnisotropyBarnLamp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also https://github.com/KhronosGroup/glTF-Sample-Assets/tree/main/Models/GlamVelvetSofa#reference-photos
and https://github.com/KhronosGroup/glTF-Sample-Assets/tree/main/Models/SheenChair#khr_materials_sheen
and https://github.com/KhronosGroup/glTF-Sample-Assets/tree/main/Models/StainedGlassLamp#reference-photos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since they are being redistributed, there should be some copyright and/or attribution info.
@DRx3D FYI.
Added information to the readme about the texture format decisions.
WEBP case changed to WebP
Added CC-BY-4 license for all images in the README.md
This is the first of four contracted "Hero Assets" for Khronos Group's 3D Commerce, a pair of sunglasses with an iridescent coating and featuring: