Node_Animation Model Group #426

stevk · 2018-05-29T23:00:40Z

Implements the Node_Animation model group.

Changed some of the runtime animation objects from structs to classes because the structs were causing issues with how we've been passing references.

Addresses several parts of #414
Fixes #404, #428

TODO:

I'm not sure I've correctly implemented a model for animating a curve that doesn't start at 0.
A proper texture still needs to be created to show which part of the model is supposed to be facing which way.
The validator shows an error in the bufferView for "Animation Sampler Output" for all of the models that are doing rotations. I'm not sure of the exact cause. "Accessor element at index # is not of unit length: 2."
I'm sure we can pick better values for the animations that what is currently plugged in.
Maybe we should add a notes column to describe the expected animation for each model?

bghgary · 2018-05-29T23:16:34Z

Source/ModelGroups/Node_Animation.cs

+            Model CreateModel(Action<List<Property>, List<Runtime.Channel>, Runtime.Node> setProperties)
+            {
+                var properties = new List<Property>();
+                var cube = Gltf.CreateCube();


Return primitive instead of gltf

bghgary · 2018-05-29T23:22:27Z

Source/ModelGroups/Node_Animation.cs

+
+namespace AssetGenerator
+{
+    internal class Node_Animation : ModelGroup


Node_Animation -> Animation_Node

bghgary · 2018-05-30T20:18:22Z

Output/Animation_Node/README.md

+
+The following table shows the properties that are set for a given model.  
+
+|   | Sample Image | Translation | Rotation | Scale | Interpolation |


Let's try a single column for Target(s) and list the targets.

The (s) causes an error when used as a enum, so I went with Targets instead.

bghgary · 2018-05-30T20:21:12Z

Source/Runtime/Animation.cs

    {
        public String Name { get; set; }
-        public List<AnimationChannel> AnimationChannels { get; set; }


Restore the Animation prefix for types.

bghgary · 2018-05-30T20:26:01Z

Source/ModelGroups/Animation_Node.cs

+                channels.Add(new Runtime.Channel());
+                channels.Add(new Runtime.Channel());
+
+                SetTranslationChannelTarget(properties, channels[0], node);


create a new properties list and then combine the strings afterwards into the real properties list

bghgary · 2018-05-30T20:35:56Z

Source/ModelGroup_Cube.cs

+                            new Vector2(1.000f, 0.000f),
+                            new Vector2(0.500f, 0.000f),
+
+                            // Right


Left <-> Right

bghgary · 2018-05-30T20:41:44Z

Source/ModelGroups/Animation_Node.cs

+                    },
+                    new List<Quaternion>
+                    {
+                        new Quaternion(0, 0, 0, 0),


Show Right, Front, then Left

bghgary · 2018-05-30T20:44:09Z

Source/ModelGroups/Animation_Node.cs

+                properties.Add(new Property(PropertyName.Scale, ":white_check_mark:"));
+            }
+
+            void SetLinearSampler(List<Property> properties, Runtime.Channel channel)


Create a new function for Scale and rename this to be specific for Translation. Make scale half, normal, double

I made scale loop as well. Is it really nessessary to specify the 0,0,0 value? As far as I can tell, setting that middle value doesn't make a difference due to being exactly between the min/max values with equal time spacing between.

In reference to the linear sampler. It makes sense for the step sampler.

bghgary · 2018-05-30T20:47:32Z

Source/ModelGroups/Animation_Node.cs

+                        {
+                            InTangent = new Vector3(1, 1, 1),
+                            Value = new Vector3(0.1f, 0.1f, 0.1f),
+                            OutTangent = new Vector3(1, 1, 1)


Change to zero.

bghgary · 2018-05-30T20:48:12Z

Source/ModelGroups/Animation_Node.cs

+                        new Runtime.CubicSplineSampler<Vector3>.Key
+                        {
+                            InTangent = new Vector3(0, 0, 0),
+                            Value = new Vector3(1, 1, 1),


stevk · 2018-05-30T23:49:30Z

Looking into #428 tomorrow for model 06. The model also appears to change scale when rotating, but I'm not sure if that is an issue or not.

…nnels

bghgary · 2018-05-31T17:28:36Z

Source/ModelGroups/Animation_Node.cs

+                properties.Add(new Property(PropertyName.Interpolation, "Cubic Spline"));
+            }
+
+            void SetLinearSamplerForRotation(List<Property> properties, Runtime.AnimationChannel channel)


Move this with the linear functions

bghgary · 2018-06-01T22:38:49Z

Output/Animation_Node/README.md

@@ -0,0 +1,15 @@
+These models are intended to test the basic attributes of animation on a node.  
+
+The last model on this list creates a curve which doesn't start at Zero.  


Remove this

bghgary · 2018-06-01T22:39:45Z

Source/Runtime/AnimationChannelTarget.cs

@@ -1,6 +1,6 @@
 namespace AssetGenerator.Runtime
 {
-    internal struct AnimationChannelTarget
+    internal class ChannelTarget


Revert this

I meant the name and not the class to struct change.

Oops, switched that back around.

bghgary · 2018-06-01T22:40:08Z

Source/Property.cs

@@ -142,6 +142,8 @@ internal enum PropertyName
        Translation,
        Rotation,
        Scale,
+        Targets,


Change to singular

stevk added 4 commits May 29, 2018 09:35

Initial setup for node animation

209ddd1

Initial commit for the Node_Animation model group

33fb394

Fix Mesh_Primitives log

9e44602

Fix modelgroup order

a429363

stevk self-assigned this May 29, 2018

stevk requested review from kcoley and bghgary May 29, 2018 23:00

bghgary and others added 6 commits May 29, 2018 16:39

Code review changes

3680471

Use checkmarks to make the readme make more sense

f905cc7

Fix cube code to return a meshprimitive instead of a gltf

998cc71

Rename Node_Animation to Animation_Node

d695f03

Update comments

5588751

Update cube texture coords and texture to better show facing

fadff24

bghgary reviewed May 30, 2018

View reviewed changes

Action feedback

5726490

Add a quick fix so that the correct sampler is used with multiple cha…

5c593ff

…nnels

bghgary reviewed May 31, 2018

View reviewed changes

stevk and others added 4 commits May 31, 2018 10:43

Action feedback

1ffc8e7

Fix cubic spline values

9af7f3f

Increace model size

f77636e

Update cube texture

889ff8d

bghgary reviewed Jun 1, 2018

View reviewed changes

stevk added 2 commits June 6, 2018 15:48

Action feedback

f6722c4

Action feedback

fc203aa

bghgary approved these changes Jun 7, 2018

View reviewed changes

stevk merged commit c9c16e6 into KhronosGroup:master Jun 7, 2018

stevk deleted the nodeanimation branch June 7, 2018 16:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Node_Animation Model Group #426

Node_Animation Model Group #426

stevk commented May 29, 2018 •

edited

Loading

bghgary May 29, 2018

bghgary May 29, 2018

bghgary May 30, 2018

stevk May 30, 2018

stevk May 30, 2018

bghgary May 30, 2018

stevk May 30, 2018

bghgary May 30, 2018

stevk May 30, 2018

bghgary May 30, 2018

stevk May 30, 2018

bghgary May 30, 2018

bghgary May 30, 2018

stevk May 30, 2018

stevk May 30, 2018 •

edited

Loading

bghgary May 30, 2018

stevk May 30, 2018

bghgary May 30, 2018 •

edited

Loading

stevk commented May 30, 2018 •

edited

Loading

bghgary May 31, 2018

bghgary Jun 1, 2018

stevk Jun 6, 2018

bghgary Jun 1, 2018

stevk Jun 6, 2018

bghgary Jun 7, 2018

stevk Jun 7, 2018

bghgary Jun 1, 2018

stevk Jun 6, 2018


		The following table shows the properties that are set for a given model.

		\| \| Sample Image \| Translation \| Rotation \| Scale \| Interpolation \|

		@@ -0,0 +1,15 @@
		These models are intended to test the basic attributes of animation on a node.

		The last model on this list creates a curve which doesn't start at Zero.

Node_Animation Model Group #426

Node_Animation Model Group #426

Conversation

stevk commented May 29, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stevk May 30, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bghgary May 30, 2018 • edited Loading

Choose a reason for hiding this comment

stevk commented May 30, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stevk commented May 29, 2018 •

edited

Loading

stevk May 30, 2018 •

edited

Loading

bghgary May 30, 2018 •

edited

Loading

stevk commented May 30, 2018 •

edited

Loading