Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Node_Attribute and camera values to facillitate creating sample images #360

Merged
merged 8 commits into from
Mar 7, 2018
Merged

Change Node_Attribute and camera values to facillitate creating sample images #360

merged 8 commits into from
Mar 7, 2018

Conversation

stevk
Copy link
Contributor

@stevk stevk commented Mar 5, 2018 •
edited
Loading

  • Updates the camera values written to the manifest.
  • Textures the Node_Attribute models, to make it easier to see what is going on.
  • Changes the scale and translate values for Node_Attribute, so the model states on-camera and there is no z-fighting or clipping.
  • Removes the reference node. We can add parent-child hierarchy testing later.

This is a fix for #357
Contains some fixes for #363

@stevk stevk added this to the v0.5 milestone Mar 5, 2018
@stevk stevk self-assigned this Mar 5, 2018
@stevk stevk requested review from kcoley and bghgary March 5, 2018 23:52
@kcoley
Copy link
Collaborator

kcoley commented Mar 6, 2018 •
edited by stevk
Loading

  • Moved matrix column to the right and move matrix test model to the bottom
  • Use a positive y-translation value instead of -4.1
  • Ensure the matrix transform is identical to the translation/rotation and scale

kcoley
kcoley requested changes Mar 6, 2018
View reviewed changes
Source/ModelGroups/Node_Attribute.cs Outdated
var matrixR = Matrix4x4.CreateFromAxisAngle(new Vector3(0f, 1f, 0f), (float)(Math.PI));
var matrixS = Matrix4x4.CreateScale(2);
var matrixS = Matrix4x4.CreateScale(1.2f);
var matrixTRS = Matrix4x4.Multiply(Matrix4x4.Multiply(matrixT, matrixR), matrixS);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S * R * T

@stevk stevk merged commit 52cb33d into KhronosGroup:master Mar 7, 2018
@stevk stevk deleted the cameravalues branch March 7, 2018 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcoley kcoley kcoley approved these changes

@bghgary bghgary Awaiting requested review from bghgary

Assignees

@stevk stevk

Labels
None yet
Projects
None yet
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@stevk @kcoley