sync: Refactor clear attachment code #9478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrawAttachmentError does not provide additional information compared to generic Error. We can revisit later if dedicated error message is needed (need to improve ValidateDrawDynamicRenderingAttachment testing at first).
|
CI Vulkan-ValidationLayers build queued with queue ID 375040. |
|
CI Vulkan-ValidationLayers build # 19107 running. |
artem-lunarg
commented
Feb 19, 2025
| @@ -75,30 +74,6 @@ struct BeginRenderingCmdState { | |||
| void InitSubpassContexts(VkQueueFlags queue_flags, const vvl::RenderPass &rp_state, const AccessContext *external_context, | |||
| std::vector<AccessContext> &subpass_contexts); | |||
|
|
|||
| struct ClearAttachmentInfo { | |||
There was a problem hiding this comment.
One change is that this structure was updated (and moved to sync_commandbuffer.h) and now is a simple 5 LOC type. Also code reorganization allowed to replace some pointer with references.
|
CI Vulkan-ValidationLayers build # 19107 passed. |
arno-lunarg
approved these changes
Feb 19, 2025
| @@ -675,6 +675,8 @@ bool CommandBufferAccessContext::ValidateDrawAttachment(const Location &loc) con | |||
| } | |||
|
|
|||
| bool CommandBufferAccessContext::ValidateDrawDynamicRenderingAttachment(const Location &location) const { | |||
| // TODO: Add tests. This is never called by existing tests. | |||
There was a problem hiding this comment.
Maybe create a corresponding issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements of how clear attachment code is structured before updating corresponding error messages.