build: List soname for Android #8124
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 198524. |
|
CI Vulkan-ValidationLayers build # 16786 running. |
|
CI Vulkan-ValidationLayers build # 16786 passed. |
| # See https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/7385#issuecomment-2155788105 | ||
| target_link_options(vvl PRIVATE -Wl,-soname=libVkLayer_khronos_validation.so) |
There was a problem hiding this comment.
Why is this needed? CI currently works fine without -soname being specified. Under what exact circumstances is this actually needed?
CMake deliberately omits -soname for MODULE libraries from what I can tell.
I'd like to understand what is breaking because -soname is not being added.
There was a problem hiding this comment.
I will check tomorrow, but curious if the newest NDK breaks something (I have 25.1.8937393 locally and the issue was using 26.3)
There was a problem hiding this comment.
CMake deliberately omits -soname for MODULE libraries from what I can tell.
Which https://cmake.org/cmake/help/latest/command/add_library.html says is something only loadable by dlopen, not by -l:
A plugin that may not be linked by other targets, but may be dynamically loaded at runtime using dlopen-like functionality.
That's how the validation layers work though, right? It looks like the @lzhido linked directly to the validation layers? Don't do that, just add them to the jniLibs directory of your project: https://developer.android.com/ndk/guides/graphics/validation-layer#prebuilt-binaries. Your C++ build should be completely ignorant of their existence; they only need to be packaged.
|
closing from #7385 (comment) |
for #7385 - v2 of #8116
@Izhido can you confirm this works for you, works for me locally