docs: Link validation layer settings on the front page #6523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 46124. |
|
CI Vulkan-ValidationLayers build # 13619 running. |
|
CI Vulkan-ValidationLayers build # 13619 passed. |
juan-lunarg
suggested changes
Sep 20, 2023
| @@ -1,15 +1,19 @@ | |||
| # Vulkan Validation Layers (VVL) | |||
| # Vulkan Validation Layer (VVL) | |||
There was a problem hiding this comment.
The repo is called the Vulkan-ValidationLayers. I'd prefer not to change that in this PR.
I know it's technically 1 layer. But I'd prefer to leave it alone for now.
There was a problem hiding this comment.
Closing, I let you resolve #4667 the way you want.
There was a problem hiding this comment.
?
Most of this PR looks good. It's just that there are multiple places where we reference this as the validation layers. So we can't just change it in 1 place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #4667
When KhronosGroup/Vulkan-Utility-Libraries#85 will be merged we can change the link of the layer configurations to point the new shared and common documentation.