Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layer: remove VK_LAYER_SETTING_TYPE_FRAMESET_EXT #84

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

christophe-lunarg
Copy link
Contributor

No description provided.

@christophe-lunarg christophe-lunarg added enhancement New feature or request P1 labels Aug 29, 2023
@christophe-lunarg christophe-lunarg self-assigned this Aug 29, 2023
@christophe-lunarg christophe-lunarg force-pushed the remove-frameset-ext branch 2 times, most recently from ef850aa to 7837834 Compare August 29, 2023 15:16
Copy link
Contributor

@juan-lunarg juan-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ideally add an explanation for the change in the commit/PR message

After VK_EXT_layer_settings spec review, this new type
was judge unnecessary because it could be express by
three uint32. However, it still remains useful for the
layer settings library to correctly interpret formated
strings that represent "framesets".
@christophe-lunarg
Copy link
Contributor Author

This PR will break the validation layer and the profiles layer, so I am not merging it because I created the PRs in the profiles and validation layers repositories.

@christophe-lunarg
Copy link
Contributor Author

LGTM, ideally add an explanation for the change in the commit/PR message

Message updated.

@christophe-lunarg
Copy link
Contributor Author

I updated the branch with Validation layer and profiles layer. This doesn't break compatibility.

@christophe-lunarg christophe-lunarg merged commit 33e9ad7 into main Aug 30, 2023
21 checks passed
@christophe-lunarg christophe-lunarg deleted the remove-frameset-ext branch August 30, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants