headers: Fix dispatch table formatting #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code did not follow the provided clang-format file, which causes conflict when a developer runs clang-format on the repo. This commit fixes the generator so that the output is what clang-format would generate. One issue is that clang-format's ColumnLimit will wrap long lines, and is very difficult to replicate in python code without excessive changes. The chosen solution is to use a custom clang-format file for the Utilities folder which ignores the ColumnLimit.
juan-lunarg
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code did not follow the provided clang-format file, which causes conflict when a developer runs clang-format on the repo. This commit fixes the generator so that the output is what clang-format would generate. One issue is that clang-format's ColumnLimit will wrap long lines, and is very difficult to replicate in python code without excessive changes. The chosen solution is to use a custom clang-format file for the Utilities folder which ignores the ColumnLimit.