build: Update to header 1.3.262 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mikes-lunarg
commented
Aug 25, 2023
mikes-lunarg
commented
- Update known-good
- Generate source
- Update known-good - Generate source
| @@ -62,31 +63,31 @@ typedef struct VulInstanceDispatchTable_ { | |||
| PFN_vkCreateDisplayPlaneSurfaceKHR CreateDisplayPlaneSurfaceKHR; | |||
| #ifdef VK_USE_PLATFORM_XLIB_KHR | |||
| PFN_vkCreateXlibSurfaceKHR CreateXlibSurfaceKHR; | |||
| #endif // VK_USE_PLATFORM_XLIB_KHR | |||
| #endif //VK_USE_PLATFORM_XLIB_KHR | |||
There was a problem hiding this comment.
Did the file accidentally get run with clang-format before being checked in?
Seems like a reason to fix the code-gen, but for now a big change here is fine.
There was a problem hiding this comment.
Yes it looks like the following commit had clang-format applied before checking in: 2bd0e0d
I didn't run clang-format on this PR so all those formatting changes got reverted
There was a problem hiding this comment.
I'm going ahead and working on a fix so that its clang-format compliant.
juan-lunarg
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.