util: Fixup and add Layer Dispatch Table headers #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan-lunarg
reviewed
Aug 22, 2023
juan-lunarg
reviewed
Aug 22, 2023
charles-lunarg
force-pushed
the
add_layer_dispatch_tables
branch
from
d268a94
to
8936d32
Compare
juan-lunarg
reviewed
Aug 22, 2023
juan-lunarg
reviewed
Aug 22, 2023
charles-lunarg
force-pushed
the
add_layer_dispatch_tables
branch
3 times, most recently
from
ee2ad3f
to
39fb8f7
Compare
juan-lunarg
reviewed
Aug 23, 2023
charles-lunarg
force-pushed
the
add_layer_dispatch_tables
branch
from
39fb8f7
to
7ccda3a
Compare
juan-lunarg
suggested changes
Aug 23, 2023
charles-lunarg
force-pushed
the
add_layer_dispatch_tables
branch
from
7ccda3a
to
c8b671c
Compare
charles-lunarg
force-pushed
the
add_layer_dispatch_tables
branch
2 times, most recently
from
b15c42c
to
1f6389a
Compare
juan-lunarg
reviewed
Aug 23, 2023
juan-lunarg
approved these changes
Aug 23, 2023
charles-lunarg
force-pushed
the
add_layer_dispatch_tables
branch
from
1f6389a
to
a14da03
Compare
Fixes the vk_layer_dispatch_table.h header file so that they can be used in other projects. The contents of this header and vk_dispatch_table_helper.h have been moved into a new header vul_dispatch_table.h. The structs VulDeviceDispatchTable and VulInstanceDispatchTable struct contain function pointers for the device and instance, respectively. The functions vul_init_device_dispatch_table and vul_init_instance_dispatch_table fill out the aforementioned structs, making the task of setting up the disptach table in a layer much simpler.
charles-lunarg
force-pushed
the
add_layer_dispatch_tables
branch
from
a14da03
to
50657e6
Compare
juan-lunarg
reviewed
Aug 23, 2023
| (Code generation does **not** happen automatically at build time.) |
There was a problem hiding this comment.
Suggested change
| (Code generation does **not** happen automatically at build time.) | |
| Code generation does **not** happen automatically at build time. To make the library more consumable. |
There was a problem hiding this comment.
I think theres been enough force pushes for one PR 😛
There was a problem hiding this comment.
Yeah that's a FFTI no worries
There was a problem hiding this comment.
To make the library more consumable.
Also thats a sentence fragment. what is making the library more consumable? Should just drop the period.
juan-lunarg
reviewed
Aug 23, 2023
| typedef PFN_vkVoidFunction(VKAPI_PTR *PFN_GetPhysicalDeviceProcAddr)(VkInstance instance, const char *pName); | ||
|
|
||
| // Instance function pointer dispatch table | ||
| typedef struct VulInstanceDispatchTable_ { |
There was a problem hiding this comment.
VulInstanceDispatchTable_ ? why the underscore
There was a problem hiding this comment.
Thats how C types are defined - notice the VulInstanceDispatchTable after the }.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the vk_layer_dispatch_table.h and vk_dispatch_table_helper.h header files so that they can be used in other projects.
The vk_layer_dispatch_table.h header contains the VkLayerDispatchTable struct containing device function pointers and the VkLayerInstanceDispatchTable struct containing instance function pointers. These structs simplify the storage of Vulkan function pointers.
The vk_dispatch_table_helper.h header contains functions which fill out the structs defined in vk_layer_dispatch_table.h with function pointers. These functions automate acquiring the function pointers to the next layer in the chain.