-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profiles: Update to header 264 #496
Conversation
CI VulkanProfiles build # 2749 running. |
1 similar comment
CI VulkanProfiles build # 2749 running. |
CI VulkanProfiles build # 2749 failed. |
9429db5
to
38979bb
Compare
CI VulkanProfiles build queued with queue ID 40803. |
1 similar comment
CI VulkanProfiles build queued with queue ID 40803. |
CI VulkanProfiles build # 2751 running. |
CI VulkanProfiles build # 2751 failed. |
scripts/known_good.json
Outdated
}, | ||
{ | ||
"name": "Vulkan-Utility-Libraries", | ||
"url": "https://github.com/KhronosGroup/Vulkan-Utility-Libraries.git", | ||
"sub_dir": "Vulkan-Utility-Libraries", | ||
"build_dir": "Vulkan-Utility-Libraries/build", | ||
"install_dir": "Vulkan-Utility-Libraries/build/install", | ||
"commit": "v1.3.263", | ||
"commit": "v1.3.264", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to use ba0d57a51424de68a86326e393a65b26373e1c1f to pass the test I believe but I don't understand why and what's going on @juan-lunarg might know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TLDR: Utility libraries was exporting compiler options it shouldn't have been. ba0d57a51424de68a86326e393a65b26373e1c1f addresses that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's how I resolved this PR ^_^
@ziga-lunarg, I am pulling the branch to resolve this |
No description provided.