Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles: Update to header 264 #496

Merged
merged 2 commits into from
Sep 12, 2023
Merged

profiles: Update to header 264 #496

merged 2 commits into from
Sep 12, 2023

Conversation

ziga-lunarg
Copy link
Contributor

No description provided.

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build # 2749 running.

1 similar comment
@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build # 2749 running.

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build # 2749 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build queued with queue ID 40803.

1 similar comment
@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build queued with queue ID 40803.

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build # 2751 running.

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build # 2751 failed.

},
{
"name": "Vulkan-Utility-Libraries",
"url": "https://github.com/KhronosGroup/Vulkan-Utility-Libraries.git",
"sub_dir": "Vulkan-Utility-Libraries",
"build_dir": "Vulkan-Utility-Libraries/build",
"install_dir": "Vulkan-Utility-Libraries/build/install",
"commit": "v1.3.263",
"commit": "v1.3.264",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to use ba0d57a51424de68a86326e393a65b26373e1c1f to pass the test I believe but I don't understand why and what's going on @juan-lunarg might know.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TLDR: Utility libraries was exporting compiler options it shouldn't have been. ba0d57a51424de68a86326e393a65b26373e1c1f addresses that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how I resolved this PR ^_^

@christophe-lunarg
Copy link
Collaborator

@ziga-lunarg, I am pulling the branch to resolve this

@christophe-lunarg christophe-lunarg merged commit 5074ebe into main Sep 12, 2023
13 checks passed
@christophe-lunarg christophe-lunarg deleted the header-264 branch September 12, 2023 15:35
@christophe-lunarg christophe-lunarg restored the header-264 branch September 14, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants