layer: Fix dispatch table memory leak #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI VulkanProfiles build queued with queue ID 24583. |
|
CI VulkanProfiles build # 2706 running. |
|
CI VulkanProfiles build # 2706 passed. |
christophe-lunarg
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Profiles layer leaks memory on exit because the dispatch tables allocated never get destroyed.
This is observable by running some tests with AddressSanitizer.
The source has
destroy_device_dispatch_tableanddestroy_instance_dispatch_tablefunctions that are supposed to delete these allocations, but they are never called from anywhere.Instead, this fix simply uses
unique_ptrs to make sure that these allocations always get released when the layer is unloaded.