Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layer: Fix invalid feature warning #480

Merged

Conversation

aqnuep
Copy link
Contributor

@aqnuep aqnuep commented Aug 16, 2023

The Profiles layer generates warnings if a profile disables a feature that is otherwise supported by the device with messages like this:

'%s' profile value is enabled in the profile, but the device (%s) does not support it.

That just doesn't make sense, as such warnings should only be generated if a profile would want to enable a feature that is not supported by the device.

This change fixes that.

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build queued with queue ID 24468.

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build # 2704 running.

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build # 2704 passed.

@christophe-lunarg christophe-lunarg merged commit 35676e5 into KhronosGroup:main Aug 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants