scripts: Improve handling of API variants #477
Conversation
|
CI VulkanProfiles build queued with queue ID 23133. |
|
CI VulkanProfiles build # 2696 running. |
|
CI VulkanProfiles build # 2696 passed. |
aqnuep
force-pushed
the
api-variant-improvements
branch
from
a2c5ca5
to
16b8231
Compare
|
CI VulkanProfiles build queued with queue ID 23143. |
|
CI VulkanProfiles build # 2697 running. |
|
CI VulkanProfiles build # 2697 passed. |
christophe-lunarg
added
enhancement
|
@aqnuep, I think I would feel a little more confident about this if I had a better idea of what specific cases it resolves. For example, could you had some tests, maybe adding "profiles" here E:\Github\khronos\Vulkan-Profiles - Bugfix\profiles\test\data and manually checking the specific cases in E:\Github\khronos\Vulkan-Profiles - Bugfix\layer\tests\tests_mechanism.cpp ? |
| @@ -1421,7 +1455,7 @@ def __init__(self, xml, upperCaseName): | |||
| self.limits = dict() | |||
| self.platform = xml.get('platform') | |||
| self.provisional = xml.get('provisional') | |||
| self.promotedTo = xml.get('promotedto') | |||
| self.promotedTo = xml.get('promotedto').split(',') if xml.get('promotedto') is not None else [] | |||
There was a problem hiding this comment.
Is there a case where an extension is promoted to multiple extensions? Or is this for promotedto an extension and a core version maybe?
There was a problem hiding this comment.
That is one example, but also consider API variants like Vulkan SC.
|
I think the changes are mostly to better handle Vulkan and Vulkan SC it seems reasonnable. It looks like it also fix some cases regarding promotedto and alias for which I could enjoy seeing additional tests to prevent future changes accidently break these cases. |
|
Yes, most of these were detected by testing against Vulkan SC content, but are rather generic fixes so far. The problem is that in order to write tests for this you'd actually have to create custom vk.xml inputs to test with, e.g. one where |
This PR introduces some improvements to the generator scripts to better handle API variants defined in the vk.xml, as the previous code did not handle some of the aspects of the new vk.xml syntaxes introduced for API variant dependent definitions in a general way.