Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undeprecate legacy multi_ptr #604

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Undeprecate legacy multi_ptr #604

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b393ab6
Undeprecate legacy multi_ptr
steffenlarsen Aug 16, 2024
f495a77
Remove alias deprecation note
steffenlarsen Aug 29, 2024
8373205
Remove deprecation entry in changelog
steffenlarsen Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions adoc/chapters/programming_interface.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9138,7 +9138,6 @@ For interoperability with the <<backend>>, users should rely on types exposed by
the decorated version.
If the value of [code]#access::decorated# is [code]#access::decorated::legacy#,
the 1.2.1 interface is exposed.
This interface is deprecated.

The template traits [code]#remove_decoration# and type alias
[code]#remove_decoration_t# retrieve the non-decorated pointer or reference from
Expand Down Expand Up @@ -9847,10 +9846,6 @@ below.
include::{header_dir}/pointer.h[lines=4..-1]
----

Note that using [code]#global_ptr#, [code]#local_ptr#, [code]#constant_ptr# or
[code]#private_ptr# without specifying the decoration is deprecated.
The default argument is provided for compatibility with 1.2.1.


[[subsec:samplers]]
=== Image samplers
Expand Down
2 changes: 1 addition & 1 deletion adoc/headers/multipointer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ enum class address_space : /* unspecified */ {
enum class decorated : /* unspecified */ {
no,
yes,
legacy // Deprecated in SYCL 2020
legacy
};

} // namespace access
Expand Down
2 changes: 0 additions & 2 deletions adoc/headers/multipointerlegacy.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
namespace sycl {

// Legacy interface, inherited from 1.2.1.
// Deprecated.
template <typename ElementType, access::address_space Space>
class [[deprecated]] multi_ptr<ElementType, Space, access::decorated::legacy> {
public:
Expand Down Expand Up @@ -162,7 +161,6 @@ class [[deprecated]] multi_ptr<ElementType, Space, access::decorated::legacy> {
};

// Legacy interface, inherited from 1.2.1.
// Deprecated.
// Specialization of multi_ptr for void and const void
// VoidType can be either void or const void
template <access::address_space Space>
Expand Down