[SPIR-V 1.1] SPIRVReader: Add OpSizeOf support #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `OpSizeOf` instruction was added in SPIR-V 1.1, but not supported yet.
vmaksimo
reviewed
Nov 11, 2024
Comment on lines
+3
to
+4
| ; TODO: reenable spirv-val when OpSizeOf is supported. | ||
| ; R/U/N: spirv-val %t.spv |
There was a problem hiding this comment.
Is there already an issue in SPIRV-Tools?
There was a problem hiding this comment.
Yes, spirv-val doesn't know much about OpSizeOf yet. I'm preparing a PR to fix that.
There was a problem hiding this comment.
Just an issue reported to SPIR-V Tolls would have been good enough for now, but that's great your fix is already in progress :)
There was a problem hiding this comment.
For reference, the fix is here: KhronosGroup/SPIRV-Tools#5879
(but even if that lands soon, we'll need to wait for the next SPIRV-Tools release before we can re-enable this check in CI.)
Some day hopefully. For now I'm focusing on the consumption side only. |
vmaksimo
approved these changes
Nov 12, 2024
MrSidims
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OpSizeOfinstruction was added in SPIR-V 1.1, but not supported yet.