Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add len and group attributes to glx.xml #633

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NogginBops
Copy link
Contributor

Similar to #569 but for glX.

Comment on lines +1054 to +1058
<param kind="String">const <ptype>GLubyte</ptype> *<name>procName</name></param>
</command>
<command>
<proto><ptype>__GLXextFuncPtr</ptype> <name>glXGetProcAddress</name></proto>
<param>const <ptype>GLubyte</ptype> *<name>procName</name></param>
<param kind="String">const <ptype>GLubyte</ptype> *<name>procName</name></param>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully remember, but didn't we agree on something like gl::String to reference another XML document?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was under the impression that that was for enumerated groups only. I think we could possibly extend it but then I think that requires further changes to the xml schema

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right, this is the first time the kind attribute appeared outside of gl.xml.

Well, it's only slightly bugging me that the description is in another XML file.

I'm fine with keeping kinds non-namespaced, in case you think we wouldn't need that separation, but let's agree on this now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I'm fine with both.
I personally think we won't need namespaces for kinds as I don't think we'll need the same name to mean different things in the different xml files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants