-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🦀 Rust Rewrite #2
Draft
Khenziii
wants to merge
23
commits into
master
Choose a base branch
from
rust-rewrite
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have also added the .idea/ folder to .gitignore
screw this, lol. We're going to write it all from scratch.
Turns out, that the authors field is expecting a type of string[] instead of string. I'm surprised, that rust rover didn't catch this.
Khenziii
force-pushed
the
rust-rewrite
branch
from
January 20, 2024 14:20
b499d13
to
9586e96
Compare
I use arch btw. Nah, just kidding, lmao. I still touch grass (sometimes). I use Ubuntu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out, that writing a chess bot using Python is not the best idea, lol. The language is way too slow for the task (we're analyzing thousands of positions).
Rewriting everything in rust should solve the problem :gigachad: