Documentation on moving off of Underscore to ES6/7 #28
Conversation
|
I really like the table that @csilvers made here: https://github.com/Khan/style-guides/blob/master/style/javascript.md#es67-rules Some of them need extended descriptions but for some of the simple cases having 4-5 paragraphs of text is cumbersome. |
| should instead become: | ||
|
|
||
| ```js | ||
| () => { ... } |
There was a problem hiding this comment.
With args, do we prefer (...args) => { someFn(...args) }? There was some talk about this the other day.
There was a problem hiding this comment.
If you do obj.someFn.bind(this) that has the same effect (the args are still passed in). I'm not sure I really see the benefit of having to write another wrapper function!
|
@xymostech hmm, good point! I'm not entirely sure what the best way to format it, though as even if some can fit in a table, and some won't, having them remain in alphabetical order seems to be the most important aspect. (and even for many of the "simple" cases it's still multiple lines of code for the change - I suspect that trying to fit it into a table will probably end up cramping the result) |
| @@ -27,6 +27,7 @@ | |||
| * [Do not use async/await or generators](#do-not-use-asyncawait-or-generators) | |||
| * [Do not use Set or Map ](#do-not-use-set-or-map) | |||
| * [Use let and const for new files; do not use var ](#use-let-and-const-for-new-files-do-not-use-var) | |||
| * [Move off Underscore](#move-off-underscore) | |||
There was a problem hiding this comment.
This should go into the 'library rules' section.
Also, most of this audience is written with the point of view that the audience is about to write new code, so 'move off' might be better phrased as "Avoid underscore" or something like that.
… everyone's feedback.
|
@xymostech I moved to using a table instead of the longer list. Thanks for the suggestion! |
| Method | Use... | ...instead of | ||
| --------- | ------------------------------------- | ---------------------- | ||
| bind | `fn.bind(someObj, args)` | `_.bind(fn, someObj, args)` | ||
| bind | `() => { ... }` | `_.bind(function() { ... }, this)` |
There was a problem hiding this comment.
Not sure I totally understand the difference between these two. Is the second one used when binding this, and the first one used in other situations?
In particular, it might be useful to have the second example have some args, if appropriate, something like (a, b) => { ... }. Otherwise I might assume this is only to be used in the no-arg case.
There was a problem hiding this comment.
Correct - the second one is specifically when you are just binding to this (and ideally when you're declaring the function there, as well). I'll add a footnote and add some args, too.
|
Is looking great -- I love the tabel! You did miracles with the formatting. I had a bunch of line notes, but were all for low-level details. High level, I think it's looking great. |
Documentation on moving off of Underscore to ES6/7
| isArray | `Array.isArray(someObj)` | `_.isArray(someObj)` | ||
| isFunction | `typeof fn === "function"` | `_.isFunction(fn)` | ||
| isString | `typeof obj === "string"` | `_.isString(obj)` | ||
| keys | `Object.keys(obj)` | `_.keys(obj)` |
There was a problem hiding this comment.
keys |
Object.keys(obj)|_.keys(obj)
_.keys(obj) also smooths over inconsistencies in environments handling strings, arguments objects, and arrays (treating them as dense). For example, in ES5 Object.keys('hi') would throw, while in ES6 Object.keys('hi') returns ['0','1'].
This goes through all the methods that we used in shared-package.js and provides modern alternatives to the methods. Can be expanded in the future!