Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert image editor change, Graphie #646

Closed
wants to merge 2 commits into from

Conversation

nixterrimus
Copy link
Contributor

Summary:

Revert "Fix: Image widget editor fails to calculate image dimensions (#618)"

Issue: XXX-XXXX

Test plan:

@nixterrimus nixterrimus self-assigned this Aug 4, 2023
@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2023

🦋 Changeset detected

Latest commit: 6c44662

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@khanacademy/perseus-editor Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/slow-sloths-build.md, packages/perseus/src/util.ts, packages/perseus-editor/src/widgets/image-editor.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@khan-actions-bot khan-actions-bot requested a review from a team August 4, 2023 16:38
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Size Change: -179 B (0%)

Total Size: 824 kB

Filename Size Change
packages/perseus-editor/dist/es/index.js 268 kB -70 B (0%)
packages/perseus/dist/es/index.js 397 kB -109 B (0%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38 kB
packages/kmath/dist/es/index.js 4.13 kB
packages/math-input/dist/es/index.js 79.3 kB
packages/perseus-core/dist/es/index.js 55 B
packages/perseus-error/dist/es/index.js 705 B
packages/perseus-linter/dist/es/index.js 21.2 kB
packages/pure-markdown/dist/es/index.js 3.65 kB
packages/simple-markdown/dist/es/index.js 12.6 kB

compressed-size-action

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

npm Snapshot: Published

🎉 Good news!! We've packaged up the latest commit from this PR (f4a8c41) and published it to npm. You
can install it using the tag PR646.

Example:

yarn add @khanacademy/perseus@PR646

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 68.993% (+0.02%) from 68.978% when pulling 6c44662 on new/revert-editor-change into 6939f12 on main.

@nixterrimus nixterrimus closed this Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants