Add a switch component to toggle between v1 and v2 keypads #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e7a3335 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
handeyeco
changed the title
|
Size Change: -483 B (0%) Total Size: 824 kB
ℹ️ View Unchanged
|
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (25d7c21) and published it to npm. You Example: yarn add @khanacademy/perseus@PR630 |
jeremywiebe
approved these changes
Jul 27, 2023
| import {LegacyKeypad} from "@khanacademy/math-input"; | ||
| import {Keypad} from "@khanacademy/math-input"; |
There was a problem hiding this comment.
This is a nice outcome for this PR. As we begin removing the Legacy Keypad, perseus will be impacted less and less.
handeyeco
added a commit
that referenced
this pull request
Jul 27, 2023
* add useV2Keypad API option * changeset * remove name from TODO * Add a switch component to toggle between v1 and v2 keypads (#630) * add a switch component between v1 and v2 keypads * changeset * really remove name this time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
So originally I thought I would just switch between the v1 and v2 keypads in Webapp using a feature flag when I thought the keypads were exclusively rendered in footers. When I tried that, I realized that ArticleRenderer uses ProvideKeypad and thus renders the keypad internally in Perseus.
To make things simple-ish, I decided to just export one keypad from MathInput: a wrapper around both LegacyKeypad and MobileKeypad with a new prop to switch between them. Then I used the new API Option from #629 to switch in ProvideKeypad.
Next step is to use this new switching keypad in webapp where we render the keypad in the footer (for ServerItemRenderer) and add the
useV2KeypadAPI option (for Item/ArticleRenderer) - both of which will be true/false depending on the feature flag.Test plan: