Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump flowgen to handle forwardRef components better #614

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Conversation

jeremywiebe
Copy link
Collaborator

Summary:

I was noticing that our Flow types were causing a syntax error. Tracked it down to incorrect Flow type generation for forward ref components. Bumping to a newer version of flowgen fixes this.

Issue: LC-950

Test plan:

yarn; yarn build:flowtypes

Review the generated types for ServerItemRenderer (packages/perseus/dist/server-item-renderer.js.flow) and verify it doesn't use types that don't exist in the React Flow libdefs.

@jeremywiebe jeremywiebe self-assigned this Jul 17, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2023

🦋 Changeset detected

Latest commit: 3715b0f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jeremywiebe jeremywiebe requested review from kevinbarabash and a team July 17, 2023 18:19
@jeremywiebe jeremywiebe marked this pull request as ready for review July 17, 2023 18:23
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023

Size Change: 0 B

Total Size: 823 kB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38 kB
packages/kmath/dist/es/index.js 4.13 kB
packages/math-input/dist/es/index.js 78 kB
packages/perseus-core/dist/es/index.js 55 B
packages/perseus-editor/dist/es/index.js 268 kB
packages/perseus-error/dist/es/index.js 705 B
packages/perseus-linter/dist/es/index.js 21.2 kB
packages/perseus/dist/es/index.js 397 kB
packages/pure-markdown/dist/es/index.js 3.65 kB
packages/simple-markdown/dist/es/index.js 12.6 kB

compressed-size-action

@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Jul 17, 2023

Gerald

Required Reviewers
  • @Khan/perseus for changes to package.json, yarn.lock, .changeset/dry-items-applaud.md

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@coveralls
Copy link
Collaborator

coveralls commented Jul 17, 2023

Coverage Status

coverage: 69.019%. first build when pulling 3715b0f on flowgen-bump into 6ec8d96 on main.

@github-actions
Copy link
Contributor

npm Snapshot: Published

🎉 Good news!! We've packaged up the latest commit from this PR (01e5e49) and published it to npm. You
can install it using the tag PR614.

Example:

yarn add @khanacademy/perseus@PR614

Copy link
Contributor

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for upgrading flowgen. 🎉

@jeremywiebe jeremywiebe merged commit ca0e93e into main Jul 17, 2023
9 checks passed
@jeremywiebe jeremywiebe deleted the flowgen-bump branch July 17, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants