-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump flowgen to handle forwardRef components better #614
Conversation
🦋 Changeset detectedLatest commit: 3715b0f The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: 0 B Total Size: 823 kB ℹ️ View Unchanged
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (01e5e49) and published it to npm. You Example: yarn add @khanacademy/perseus@PR614 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for upgrading flowgen
. 🎉
Summary:
I was noticing that our Flow types were causing a syntax error. Tracked it down to incorrect Flow type generation for forward ref components. Bumping to a newer version of
flowgen
fixes this.Issue: LC-950
Test plan:
yarn; yarn build:flowtypes
Review the generated types for
ServerItemRenderer
(packages/perseus/dist/server-item-renderer.js.flow
) and verify it doesn't use types that don't exist in the React Flow libdefs.