Numeric Input: Treat unrecognized simplify values as "required"
#2308
+166
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… simplify = accepted
…zed `simplify` values as "required"
benchristel
commented
Mar 19, 2025
| default: | ||
| return "required"; | ||
| } | ||
| } |
There was a problem hiding this comment.
I still need to add tests for this.
|
Size Change: +235 B (+0.03%) Total Size: 735 kB
ℹ️ View Unchanged
|
benchristel
commented
Mar 19, 2025
| pipeParsers(boolean).then( | ||
| convert((value) => { | ||
| if (typeof value === "boolean") { | ||
| return value ? "required" : "optional"; |
There was a problem hiding this comment.
@SonicScrewdriver I changed the behavior here to match what the code was doing in production before this parser existed. It seems like the scoring logic treats both true and false as "required", so I removed the conditional that converts false into "optional". Please let me know if I'm missing something here!
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (4c784d8) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2308If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2308 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: I'm seeing errors in Sentry because the perseus JSON parser doesn't
understand some of the values of
simplifythat exist in production data. ThisPR ensures we accept and handle those values.
Summary:
the values of
simplifythat are in production.simplifyvaluesto equivalent ones.
Issue: none
Test plan:
yarn test