Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Fix Multiselect + Randomization only show correct for proper answers #2307

Merged
merged 2 commits into from
Mar 19, 2025
Merged

Bug fix: Fix Multiselect + Randomization only show correct for proper answers #2307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dd6cd3
[LEMS-2909] Bug fix: Fix Multiselect + Randomization only show correc…
SonicScrewdriver Mar 18, 2025
9611e6c
[LEMS-2909] docs(changeset): Revert SSS temporarily for Radio to ensu…
SonicScrewdriver Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/old-pens-hope.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@khanacademy/perseus": patch
---

Revert SSS temporarily for Radio to ensure Multiselect + Random answer correctness is accurate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't revert SSS for Radio

Suggested change
Revert SSS temporarily for Radio to ensure Multiselect + Random answer correctness is accurate
Bugfix: Multiselect + Random in Radio sometimes displays items as correct erroneously.

1 change: 1 addition & 0 deletions packages/perseus/src/widgets/radio/radio.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ const _choiceTransform = (
return {
...choice,
originalIndex: i,
correct: Boolean(choice.correct),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be beneficial to have tests. I didn't trigger any failures when making this change, so there must be a gap in our coverage. Nothing's stopping me from making this change again in two weeks when I forget any of this ever happened.

};
});

Expand Down
Loading