Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LEMS-2772] enable strict-boolean-expressions rule and add file ignores #2302

Closed
wants to merge 8 commits into from

Conversation

tatianasnook
Copy link
Contributor

  • Added @typescript-eslint/strict-boolean-expressions rule to enforce explicit boolean expressions.
  • Configured @typescript-eslint/parser and parserOptions in .eslintrc.js to support type-aware linting.
  • Updated .eslintignore to exclude config, test, and non-source files.
  • Updated tsconfig.json to exclude files not part of the main source.
  • Temporarily disabled strict-boolean-expressions errors using inline and file-level eslint-disable comments.

Copy link
Contributor

github-actions bot commented Mar 17, 2025

Size Change: -2.98 kB (-0.34%)

Total Size: 873 kB

Filename Size Change
packages/kas/dist/es/index.js 39.7 kB +71 B (+0.18%)
packages/kmath/dist/es/index.js 11.2 kB +31 B (+0.28%)
packages/math-input/dist/es/index.js 77.7 kB +137 B (+0.18%)
packages/perseus-core/dist/es/index.js 32 kB +133 B (+0.42%)
packages/perseus-editor/dist/es/index.js 275 kB -943 B (-0.34%)
packages/perseus-linter/dist/es/index.js 20 kB -2.83 kB (-12.42%) 👏
packages/perseus-score/dist/es/index.js 20.7 kB +88 B (+0.43%)
packages/perseus/dist/es/index.js 370 kB +115 B (+0.03%)
packages/perseus/dist/es/strings.js 6.78 kB +49 B (+0.73%)
packages/pure-markdown/dist/es/index.js 4.18 kB +37 B (+0.89%)
packages/simple-markdown/dist/es/index.js 13.2 kB +128 B (+0.98%)
ℹ️ View Unchanged
Filename Size
packages/keypad-context/dist/es/index.js 760 B
packages/math-input/dist/es/strings.js 1.79 kB

compressed-size-action

Copy link
Contributor

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (4eeef33) and published it to npm. You
can install it using the tag PR2302.

Example:

pnpm add @khanacademy/perseus@PR2302

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR2302

@tatianasnook tatianasnook changed the title enable strict-boolean-expressions rule and add file ignores [LEMS-2772] enable strict-boolean-expressions rule and add file ignores Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant