[LEMS-2868] Answerless ServerItemRendererWithDebugUI #2289
Conversation
…ionally render answerless data
|
Size Change: 0 B Total Size: 875 kB ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (0f0848b) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2289If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2289 |
handeyeco
changed the title
…ererWithDebugUI to optionally use answerless data for rendering
| } from "@khanacademy/perseus-core"; | ||
|
|
||
| const createItemJson = ( | ||
| widgetOptions: PerseusExpressionWidgetOptions, | ||
| version: Version, |
There was a problem hiding this comment.
It seems like changing version to widgetVersion, adding extra keys, and modifying item 3 below is all that was done here. Did you add an item without answers somewhere? I think the big red and green chunks were just moved code, but I might have missed something.
| @@ -122,6 +125,16 @@ export const ExpressionItem3 = (args: StoryArgs): React.ReactElement => { | |||
| ); | |||
| }; | |||
|
|
|||
| export const AnswerlessExpression = (args: StoryArgs): React.ReactElement => { | |||
There was a problem hiding this comment.
Where is this used? I don't see it referenced in this PR at all.
| } from "@khanacademy/perseus-core"; | ||
|
|
||
| const createItemJson = ( | ||
| widgetOptions: PerseusExpressionWidgetOptions, | ||
| version: Version, | ||
| widgetVersion: Version = expressionLogic.version as Version, |
There was a problem hiding this comment.
Can we use satisfies instead of as here? Also, why do we need the cast at all? :)
|
I'm not sure this is working as we think it is. I could be missing something, but should the Perseus JSON section reflect the result of splitPerseusItem? In other words, should the answerful data be missing from the Perseus JSON area? In my testing, so far that's not the case. I assumed that was because we only need the render data to be missing the answers, but how do we confirm what data it's rendering with? I'm still testing since I'm working on this too, but curious if you have ideas or I missed something in regards to this. 
UPDATE: 
|
Summary:
I wanted to be able to render/use widgets in Storybook, but have them rendered using answerless data rather than the full data.
Issue: LEMS-2868