Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move constants.ts file #1804

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Move constants.ts file #1804

wants to merge 2 commits into from

Conversation

handeyeco
Copy link
Contributor

@handeyeco handeyeco commented Oct 25, 2024

Summary:

It was defined in perseus but seemed to only be used in perseus-editor, so I moved it.

@handeyeco handeyeco self-assigned this Oct 25, 2024
@khan-actions-bot khan-actions-bot requested a review from a team October 25, 2024 16:23
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Oct 25, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/shaggy-cobras-invent.md, packages/perseus/src/index.ts, packages/perseus-editor/src/content-preview.tsx, packages/perseus-editor/src/components/device-framer.tsx, packages/perseus-editor/src/components/viewport-resizer.tsx, packages/perseus-editor/src/styles/constants.ts

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@handeyeco handeyeco changed the title move constants file Move constants.ts file Oct 25, 2024
Copy link
Contributor

github-actions bot commented Oct 25, 2024

Size Change: -117 B (-0.01%)

Total Size: 866 kB

Filename Size Change
packages/perseus-editor/dist/es/index.js 281 kB +150 B (+0.05%)
packages/perseus/dist/es/index.js 419 kB -267 B (-0.06%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.8 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 77.7 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 3.4 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Oct 25, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (8e7ce7d) and published it to npm. You
can install it using the tag PR1804.

Example:

yarn add @khanacademy/perseus@PR1804

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants