-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Locked Figure Labels] Add/edit/delete locked vector labels #1652
Conversation
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (09ae084) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1652 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1652 |
Size Change: +138 B (+0.02%) Total Size: 863 kB
ℹ️ View Unchanged
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1652 +/- ##
==========================================
+ Coverage 70.71% 70.89% +0.17%
==========================================
Files 562 588 +26
Lines 107953 112587 +4634
Branches 7955 12031 +4076
==========================================
+ Hits 76336 79814 +3478
- Misses 31495 32773 +1278
+ Partials 122 0 -122 see 1150 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary:
Add the ability to add/edit/delete labels for locked vectors
within the interactive graph editor.
Issue: https://khanacademy.atlassian.net/browse/LEMS-2348
Test plan:
and updates with the vector