Collocate interactive graph editor code #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (6a82952) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1601If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1601 |
|
Size Change: -1.04 kB (-0.12%) Total Size: 859 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1601 +/- ##
==========================================
+ Coverage 70.23% 70.43% +0.20%
==========================================
Files 548 574 +26
Lines 107279 111563 +4284
Branches 5496 11824 +6328
==========================================
+ Hits 75348 78581 +3233
- Misses 31815 32982 +1167
+ Partials 116 0 -116 see 1122 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
benchristel
force-pushed
the
benc/split-interactive-graph-editor
branch
from
c332ca2
to
7e1edbe
Compare
benchristel
force-pushed
the
benc/split-interactive-graph-editor
branch
from
7e1edbe
to
4c199e5
Compare
benchristel
commented
Sep 11, 2024
| throw new UnreachableCaseError(type); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This code moved to interactive-graph-editor/locked-figures/util.ts.
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Merged
SonicScrewdriver
added a commit
that referenced
this pull request
Sep 16, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Minor Changes - [#1615](#1615) [`51b6e1431`](51b6e14) Thanks [@nicolecomputer](https://github.com/nicolecomputer)! - Aligns unlimited point user experience for mouse+touch users - [#1605](#1605) [`ddc3f5d05`](ddc3f5d) Thanks [@benchristel](https://github.com/benchristel)! - Add 'None' graph type, for graphs that should only display locked figures. ### Patch Changes - [#1632](#1632) [`cea62ad11`](cea62ad) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Minor regression fix for bounding of interactive elements in the Interactive Graph widget. - [#1622](#1622) [`12b8e01bf`](12b8e01) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Fix types for `classnames` package usages ## @khanacademy/[email protected] ### Minor Changes - [#1605](#1605) [`ddc3f5d05`](ddc3f5d) Thanks [@benchristel](https://github.com/benchristel)! - Add 'None' graph type, for graphs that should only display locked figures. ### Patch Changes - [#1601](#1601) [`ef7b35bce`](ef7b35b) Thanks [@benchristel](https://github.com/benchristel)! - Internal: Reorganize interactive graph editor files. - Updated dependencies \[[`51b6e1431`](51b6e14), [`cea62ad11`](cea62ad), [`ddc3f5d05`](ddc3f5d), [`12b8e01bf`](12b8e01)]: - @khanacademy/[email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rearranges
perseus-editorcode so components and tests that are specific to the interactive graph widget editor are closer together.Issue: none
Test plan:
Edit and save an exercise with an interactive graph widget.