Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some editor-only components into perseus-editor #1591

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

handeyeco
Copy link
Contributor

@handeyeco handeyeco commented Sep 4, 2024

Summary:

There were 4 components declared in perseus but only used in perseus-editor so I moved them.

Issue: LEMS-2321

Test plan:

Nothing should change, implementation nit

@handeyeco handeyeco self-assigned this Sep 4, 2024
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Sep 4, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/pretty-garlics-give.md, packages/perseus/src/index.ts, packages/perseus-editor/src/widgets/interaction-editor/arrow-picker.tsx, packages/perseus-editor/src/widgets/interaction-editor/color-picker.tsx, packages/perseus-editor/src/widgets/interaction-editor/dash-picker.tsx, packages/perseus-editor/src/widgets/interaction-editor/element-container.tsx, packages/perseus-editor/src/widgets/interaction-editor/function-editor.tsx, packages/perseus-editor/src/widgets/interaction-editor/interaction-editor.tsx, packages/perseus-editor/src/widgets/interaction-editor/label-editor.tsx, packages/perseus-editor/src/widgets/interaction-editor/line-editor.tsx, packages/perseus-editor/src/widgets/interaction-editor/parametric-editor.tsx, packages/perseus-editor/src/widgets/interaction-editor/point-editor.tsx, packages/perseus-editor/src/widgets/interaction-editor/rectangle-editor.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@khan-actions-bot khan-actions-bot requested a review from a team September 4, 2024 20:55
@handeyeco handeyeco changed the title move some stuff for interaction Move some editor-only components into perseus-editor Sep 4, 2024
@@ -0,0 +1,6 @@
---
"@khanacademy/perseus": major
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it's a relatively insignificant change, it's a breaking change for the external API of perseus.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (1958f58) and published it to npm. You
can install it using the tag PR1591.

Example:

yarn add @khanacademy/perseus@PR1591

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1591

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Size Change: -187 B (-0.02%)

Total Size: 859 kB

Filename Size Change
packages/perseus-editor/dist/es/index.js 275 kB +689 B (+0.25%)
packages/perseus/dist/es/index.js 417 kB -876 B (-0.21%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.3 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 78 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 3.36 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.54%. Comparing base (c875acd) to head (1958f58).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #1591     +/-   ##
=========================================
  Coverage   70.53%   70.54%             
=========================================
  Files         546      571     +25     
  Lines      106885   111388   +4503     
  Branches     5556    11243   +5687     
=========================================
+ Hits        75396    78580   +3184     
- Misses      31373    32808   +1435     
+ Partials      116        0    -116     

Impacted file tree graph

see 1117 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c875acd...1958f58. Read the comment docs.

Copy link
Collaborator

@jeremywiebe jeremywiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Good eye catching these editor-only components!

@handeyeco handeyeco merged commit 05d0480 into main Sep 9, 2024
12 of 13 checks passed
@handeyeco handeyeco deleted the LEMS-2321/move-files branch September 9, 2024 14:48
mark-fitzgerald pushed a commit that referenced this pull request Sep 10, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.


# Releases
## @khanacademy/[email protected]

### Major Changes

-   [#1591](#1591) [`05d048026`](05d0480) Thanks [@handeyeco](https://github.com/handeyeco)! - Move interaction-editor sub-components into perseus-editor

### Minor Changes

-   [#1568](#1568) [`eddcb9417`](eddcb94) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph + Editor] Add a full graph aria-label and aria-description/describedby to interactive graphs, as well as the UI for content authors to add this in the interactive graph editor

### Patch Changes

-   [#1540](#1540) [`08068dc71`](08068dc) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Resolve improperly scaled text/labels in Graphie images when viewed in mobile (constrained viewports)


-   [#1592](#1592) [`d88b0ffdf`](d88b0ff) Thanks [@benchristel](https://github.com/benchristel)! - Internal: Move tests, test data, and Storybook stories for the Interactive Graph widget to the directory specific to that widget.


-   [#1594](#1594) [`435f3f6d8`](435f3f6) Thanks [@benchristel](https://github.com/benchristel)! - Internal: Remove Storybook stories that generate random widgets


-   [#1599](#1599) [`71715afd2`](71715af) Thanks [@benchristel](https://github.com/benchristel)! - Internal: improve type safety of interactive graph editor


-   [#1590](#1590) [`6c4e9e154`](6c4e9e1) Thanks [@benchristel](https://github.com/benchristel)! - Internal: Move InteractiveGraphEditor to its own directory

## @khanacademy/[email protected]

### Minor Changes

-   [#1600](#1600) [`bdb382fda`](bdb382f) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Interactive Graph - Add example functions for copy/paste to locked functions settings


-   [#1568](#1568) [`eddcb9417`](eddcb94) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph + Editor] Add a full graph aria-label and aria-description/describedby to interactive graphs, as well as the UI for content authors to add this in the interactive graph editor

### Patch Changes

-   [#1592](#1592) [`d88b0ffdf`](d88b0ff) Thanks [@benchristel](https://github.com/benchristel)! - Internal: Move tests, test data, and Storybook stories for the Interactive Graph widget to the directory specific to that widget.


-   [#1591](#1591) [`05d048026`](05d0480) Thanks [@handeyeco](https://github.com/handeyeco)! - Move interaction-editor sub-components into perseus-editor


-   [#1594](#1594) [`435f3f6d8`](435f3f6) Thanks [@benchristel](https://github.com/benchristel)! - Internal: Remove Storybook stories that generate random widgets


-   [#1599](#1599) [`71715afd2`](71715af) Thanks [@benchristel](https://github.com/benchristel)! - Internal: improve type safety of interactive graph editor


-   [#1590](#1590) [`6c4e9e154`](6c4e9e1) Thanks [@benchristel](https://github.com/benchristel)! - Internal: Move InteractiveGraphEditor to its own directory

-   Updated dependencies \[[`08068dc71`](08068dc), [`d88b0ffdf`](d88b0ff), [`eddcb9417`](eddcb94), [`05d048026`](05d0480), [`435f3f6d8`](435f3f6), [`71715afd2`](71715af), [`6c4e9e154`](6c4e9e1)]:
    -   @khanacademy/[email protected]

## @khanacademy/[email protected]

### Patch Changes

-   [#1592](#1592) [`d88b0ffdf`](d88b0ff) Thanks [@benchristel](https://github.com/benchristel)! - Internal: Move tests, test data, and Storybook stories for the Interactive Graph widget to the directory specific to that widget.


-   [#1594](#1594) [`435f3f6d8`](435f3f6) Thanks [@benchristel](https://github.com/benchristel)! - Internal: Remove Storybook stories that generate random widgets

Author: khan-actions-bot

Reviewers: mark-fitzgerald

Required Reviewers:

Approved By: mark-fitzgerald

Checks: ❌ codecov/project, ✅ codecov/patch, ✅ Upload Coverage (ubuntu-latest, 20.x), ⏭️  Publish npm snapshot, ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald

Pull Request URL: #1597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants