-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move widgets into widget-specific folders #1585
Conversation
Size Change: 0 B Total Size: 861 kB ℹ️ View Unchanged
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (e2392f3) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1585 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1585 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for doing this!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1585 +/- ##
==========================================
+ Coverage 70.34% 70.36% +0.01%
==========================================
Files 521 579 +58
Lines 107316 112070 +4754
Branches 5513 11275 +5762
==========================================
+ Hits 75489 78853 +3364
- Misses 31711 33217 +1506
+ Partials 116 0 -116 see 1100 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Major Changes - [#1577](#1577) [`c875acd01`](c875acd) Thanks [@handeyeco](https://github.com/handeyeco)! - Remove example widgets and their editors ### Minor Changes - [#1570](#1570) [`c4432ffad`](c4432ff) Thanks [@nicolecomputer](https://github.com/nicolecomputer)! - Remove unlimited points via keyboard - [#1582](#1582) [`377b7ce68`](377b7ce) Thanks [@aemandine](https://github.com/aemandine)! - Add save warnings to PhET widget editor and un-hide widget from content editor widget dropdown ### Patch Changes - [#1578](#1578) [`78bb8573e`](78bb857) Thanks [@aemandine](https://github.com/aemandine)! - Remove simpleValidate from PhET widget - [#1585](#1585) [`a6ec402c0`](a6ec402) Thanks [@handeyeco](https://github.com/handeyeco)! - Reorganize files in the widgets folder - [#1589](#1589) [`d56952564`](d569525) Thanks [@aemandine](https://github.com/aemandine)! - Make PhET widget smaller - [#1587](#1587) [`8015cdefb`](8015cde) Thanks [@aemandine](https://github.com/aemandine)! - Tidying up PhET widget - [#1583](#1583) [`615567bd2`](615567b) Thanks [@handeyeco](https://github.com/handeyeco)! - Remove sort-comp exceptions and reorder components ## @khanacademy/[email protected] ### Major Changes - [#1577](#1577) [`c875acd01`](c875acd) Thanks [@handeyeco](https://github.com/handeyeco)! - Remove example widgets and their editors ### Minor Changes - [#1582](#1582) [`377b7ce68`](377b7ce) Thanks [@aemandine](https://github.com/aemandine)! - Add save warnings to PhET widget editor and un-hide widget from content editor widget dropdown ### Patch Changes - [#1585](#1585) [`a6ec402c0`](a6ec402) Thanks [@handeyeco](https://github.com/handeyeco)! - Reorganize files in the widgets folder - [#1587](#1587) [`8015cdefb`](8015cde) Thanks [@aemandine](https://github.com/aemandine)! - Tidying up PhET widget - [#1583](#1583) [`615567bd2`](615567b) Thanks [@handeyeco](https://github.com/handeyeco)! - Remove sort-comp exceptions and reorder components - Updated dependencies \[[`78bb8573e`](78bb857), [`a6ec402c0`](a6ec402), [`d56952564`](d569525), [`c875acd01`](c875acd), [`8015cdefb`](8015cde), [`c4432ffad`](c4432ff), [`615567bd2`](615567b), [`377b7ce68`](377b7ce)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#1585](#1585) [`a6ec402c0`](a6ec402) Thanks [@handeyeco](https://github.com/handeyeco)! - Reorganize files in the widgets folder
Summary:
Before:
After:
See: https://khanacademy.slack.com/archives/C01AZ9H8TTQ/p1725381544129369
Test plan:
Nothing should functionally change, just moving stuff