Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Interactive Graph + Editor] Add aria label and description to entire interactive graph and its UI to the editor #1568

Merged
merged 19 commits into from
Sep 6, 2024
Merged

[Interactive Graph + Editor] Add aria label and description to entire interactive graph and its UI to the editor #1568

merged 19 commits into from
Sep 6, 2024

Commits on Aug 28, 2024

  1. Add aria label and description to entire interactive graph

    @nishasy
    nishasy committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    e35b1c9 View commit details
    Browse the repository at this point in the history

  2. get rid of display none

    @nishasy
    nishasy committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    d1f4282 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into whole-graph-alt-text

    @nishasy
    nishasy committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    ce9a74a View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Merge branch 'main' into whole-graph-alt-text

    @nishasy
    nishasy committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    75f1ca2 View commit details
    Browse the repository at this point in the history

  2. Use TextArea (broken)

    @nishasy
    nishasy committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    a8b4344 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Use TextField instead of TextArea

    @nishasy
    nishasy committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    bafb67b View commit details
    Browse the repository at this point in the history

  2. Add aria describedby

    @nishasy
    nishasy committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    5124951 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into whole-graph-alt-text

    @nishasy
    nishasy committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    660805e View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Merge branch 'main' into whole-graph-alt-text

    @nishasy
    nishasy committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    67fb51c View commit details
    Browse the repository at this point in the history

  2. Add back the import for InteractiveGraphDescription that got removed … 

    …in the merge
    @nishasy
    nishasy committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    7e71914 View commit details
    Browse the repository at this point in the history

  3. Simplify onChange props

    @nishasy
    nishasy committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    0dc64a5 View commit details
    Browse the repository at this point in the history

  4. Change the variable back to fullGraphAriaDescription because describe… 

    …dBy refers specifically to an ID
    @nishasy
    nishasy committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    31eda3e View commit details
    Browse the repository at this point in the history

  5. Update test data

    @nishasy
    nishasy committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    f719e7c View commit details
    Browse the repository at this point in the history

  6. Further streamline onChange

    @nishasy
    nishasy committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    9761358 View commit details
    Browse the repository at this point in the history

  7. update comments

    @nishasy
    nishasy committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    fac3fbf View commit details
    Browse the repository at this point in the history

  8. Move aria label and description on graph to make a better navigation … 

    …experience
    @nishasy
    nishasy committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    a187885 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Add tests and make relevant changes

    @nishasy
    nishasy committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3e8002f View commit details
    Browse the repository at this point in the history

  2. Use textarea for now

    @nishasy
    nishasy committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    db5e7c4 View commit details
    Browse the repository at this point in the history

  3. changeset

    @nishasy
    nishasy committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    5456ccb View commit details
    Browse the repository at this point in the history