-
Notifications
You must be signed in to change notification settings - Fork 351
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## Summary: Perseus styles KaTeX-rendered math in specific ways for different scenarios (e.g. inline math, block math, and graphie labels). Before we release MathJax 3 to users, it should do the same for MathJax-rendered math. See also: Khan/webapp#15509 Issue: https://khanacademy.atlassian.net/browse/LC-1087 ## Test plan: Follow the instructions in webapp's `services/static/javascript/perseus/README.md` to install a dev build of Perseus. View math in the following situations with `?devflagk=mathjax3` appended to the URL and verify that it looks like the math on prod: - /devadmin/tex - /devadmin/tex/testcases - A math article, e.g. `/math/multivariable-calculus/thinking-about-multivariable-function/x786f2022:vectors-and-matrices/a/vectors-and-notation-mvc` - A math exercise - Graphie labels - The exercise editor (note the color contrast between math and the surrounding text in the mobile preview). - An interactive graph - A passage widget - A plotter widget Author: benchristel Reviewers: nixterrimus Required Reviewers: Approved By: nixterrimus Checks: ✅ finish_coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Lint, Typecheck, and Test (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ gerald Pull Request URL: #631
- Loading branch information
1 parent
fb6b9c8
commit a0c7156
Showing
6 changed files
with
20 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@khanacademy/perseus": minor | ||
--- | ||
|
||
Make KaTeX CSS styles also apply to MathJax 3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,7 +66,7 @@ | |
} | ||
} | ||
} | ||
.katex { | ||
.katex, mjx-container { | ||
line-height: @line-height - 2; | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters