wip: prevent reinitialize from hiding keyboard invitation right away

Khan · Sep 23, 2024 · 7f4e4a6 · 7f4e4a6
1 parent 0c97879
commit 7f4e4a6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/packages/perseus/src/widgets/interactive-graphs/reducer/interactive-graph-reducer.ts b/packages/perseus/src/widgets/interactive-graphs/reducer/interactive-graph-reducer.ts
@@ -215,6 +215,7 @@ function doChangeKeyboardInvitationVisibility(
         return {
             ...state,
             showKeyboardInteractionInvitation: action.shouldShow,
+            hasBeenInteractedWith: true,
         };
     }
 

diff --git a/packages/perseus/src/widgets/interactive-graphs/stateful-mafs-graph.tsx b/packages/perseus/src/widgets/interactive-graphs/stateful-mafs-graph.tsx
@@ -116,12 +116,19 @@ export const StatefulMafsGraph = React.forwardRef<
     const originalPropsRef = useRef(props);
     const latestPropsRef = useLatestRef(props);
     useEffect(() => {
+        if (state.hasBeenInteractedWith) {
+            return;
+        }
         // This conditional prevents the state from being "reinitialized" right
         // after the first render. This is an optimization, but also prevents
         // a bug where the graph would be marked "incorrect" during grading
         // even if the user never interacted with it.
         if (latestPropsRef.current !== originalPropsRef.current) {
-            dispatch(reinitialize(latestPropsRef.current));
+            dispatch(
+                reinitialize({
+                    ...latestPropsRef.current,
+                }),
+            );
         }
     }, [
         graph.type,
@@ -133,6 +140,7 @@ export const StatefulMafsGraph = React.forwardRef<
         showSides,
         latestPropsRef,
         startCoords,
+        state.hasBeenInteractedWith,
     ]);
 
     // If the graph is static, it always displays the correct answer. This is